Skip to content
This repository was archived by the owner on Jun 17, 2026. It is now read-only.

Fix stale speed controls in the editor#646

Merged
siddharthvaddem merged 1 commit into
siddharthvaddem:mainfrom
AjTheSpidey:codex/editor-settings-scroll
May 25, 2026
Merged

Fix stale speed controls in the editor#646
siddharthvaddem merged 1 commit into
siddharthvaddem:mainfrom
AjTheSpidey:codex/editor-settings-scroll

Conversation

@AjTheSpidey

@AjTheSpidey AjTheSpidey commented May 23, 2026

Copy link
Copy Markdown
Contributor

Fixes #641.

Found this while checking the speed panel. If a speed region was selected and then you switched to zoom, trim, or annotation, the old speed selection could stay active too. That makes the inspector stack the speed controls under the next timeline tool.

This clears the stale speed selection whenever another timeline item becomes active.

Local screenshots:

Speed selected:
Speed selected

After adding/selecting zoom:
Zoom selected after speed

Checked locally:

  • npm.cmd run build-vite
  • node_modules\.bin\biome.cmd check --formatter-enabled=false src/components/video-editor/VideoEditor.tsx
  • Playwright/Electron flow: opened the sample video, added speed, added zoom, and verified the speed panel hides once zoom is active

@coderabbitai

coderabbitai Bot commented May 23, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

An error occurred during the review process. Please try again later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@siddharthvaddem
siddharthvaddem merged commit 7f73f90 into siddharthvaddem:main May 25, 2026
9 checks passed
@AjTheSpidey
AjTheSpidey deleted the codex/editor-settings-scroll branch May 26, 2026 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Playback speed not visible on editor

2 participants